[PATCH] D134434: [BOLT] Support building bolt when LLVM_LINK_LLVM_DYLIB is ON

Thu Sep 22 11:55:31 PDT 2022

Amir accepted this revision.
Amir added a subscriber: rafaelauler.
Amir added a comment.
This revision is now accepted and ready to land.

In D134434#3809386 <https://reviews.llvm.org/D134434#3809386>, @Amir wrote:

> Nice. Works for me. Do you think we really need this statement `DISABLE_LLVM_LINK_LLVM_DYLIB` in all CMakeLists, or just the ones that touch LLVM's Target libraries?
> I've tried setting it only for bolt/lib/Target/*/CMakeLists.txt and it appears to build as well.

Sorry, it looks like we need to set it everywhere because otherwise some global symbols are present in both libLLVM and llvm-bolt and that causes a runtime crash:

> $ bin/llvm-bolt --version
> : CommandLine Error: Option 'aarch64-mark-bti-property' registered more than once!
> LLVM ERROR: inconsistency in registered CommandLine options
> Aborted (core dumped)

With that, LGTM. @rafaelauler @maksfb - please take a look if the change makes sense to you.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134434/new/

https://reviews.llvm.org/D134434