[PATCH] D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

In D132077#3801049 <https://reviews.llvm.org/D132077#3801049>, @ormris wrote:

> Everything should be addressed. Sorry for the delay. Things have been busy over here.
>
> In D132077#3765732 <https://reviews.llvm.org/D132077#3765732>, @aeubanks wrote:
>
>> actually I just happened to run across a case where this would be useful, but I'm getting tons of verifier errors in reduction to do with `invalid template parameter`
>
> Yes, this does lean on the verifier. It's fairly blind to the structure of DI Metadata. Did it provide a useful reduction?

IIRC I eventually gave up because it kept failing the verifier.
In its current state I think this patch can't run in the default llvm-reduce pipeline because of this. In cases with certain types of debug info (e.g. templates) it'll significantly slow down the reduce. I'm ok with adding it as a pass that isn't run by default. Or if you can somehow get the pass to not fail the verifier with templated code (i.e. `llvm-reduce --abort-on-invalid-reduction -delta-passes=di-metadata` doesn't fail on some IR with template debug info).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132077/new/

https://reviews.llvm.org/D132077