[PATCH] D129986: [NFC][LoopVectorize] Add tail-folding RUN lines to existing SVE tests

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 22 06:51:55 PDT 2022


david-arm added a comment.

In D129986#3805329 <https://reviews.llvm.org/D129986#3805329>, @CarolineConcatto wrote:

> Hey David,
> About the manual changes, why not use the python script to  add the extra check-lines for tail folding?

So for many of the existing tests, e.g. scalable-reductions.ll, we've tried in the past to keep the number of CHECK lines to a minimum because most of the CHECK lines aren't required for the thing we want to test.The vectoriser generates lots of preheader instructions, plus it leaves in a lot of unnecessary code after the vector loop too. However, this does place more burden on the engineer (i.e. me in this case!) to hand-write the CHECK lines. I do think it makes the tests a bit more readable, although that's just my opinion!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129986/new/

https://reviews.llvm.org/D129986



More information about the llvm-commits mailing list