[PATCH] D134433: [AMDGPU][GISel] Enable Matching of V2S16 G_BUILD_VECTOR

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

Looks like there are some code quality regressions to address?



================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/andn2.ll:521-522
 ; GFX9:       ; %bb.0:
-; GFX9-NEXT:    s_andn2_b32 s0, s2, s3
+; GFX9-NEXT:    s_xor_b32 s0, s3, -1
+; GFX9-NEXT:    s_and_b32 s0, s2, s0
 ; GFX9-NEXT:    ; return to shader part epilog
----------------
Regression here.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/clamp-minmax-const-combine.ll:49-51
+; GFX10-NEXT:    v_pk_mul_f16 v0, v0, 2.0 op_sel_hi:[1,0]
+; GFX10-NEXT:    v_pk_max_f16 v0, 0, v0
+; GFX10-NEXT:    v_pk_min_f16 v0, 1.0, v0 op_sel_hi:[0,1]
----------------
Regression here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134433/new/

https://reviews.llvm.org/D134433