[PATCH] D134375: [LTO][AIX] Invoking AIX System Assembler in LTO CodeGen

[Qiongsi Wu via Phabricator via llvm-commits]

qiongsiwu1 updated this revision to Diff 462150.
qiongsiwu1 added a comment.

Addressing code review:

1. The `lto-save-temp` option is removed. We will add that later with a different patch.
2. The newly added AIX specific functions are explicitly named.
3. Minor changes to variable names (`runSystemAssembler(SmallString<128> &Name)` -> `runSystemAssembler(SmallString<128> &AssemblyFile)`) and removing unnecessary comments.

Thanks for the feedback @w2yehia and @MaskRay !


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134375/new/

https://reviews.llvm.org/D134375

Files:
  llvm/include/llvm/LTO/legacy/LTOCodeGenerator.h
  llvm/lib/LTO/LTOCodeGenerator.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134375.462150.patch
Type: text/x-patch
Size: 3822 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220922/f5fc8289/attachment.bin>