[PATCH] D134380: [GlobalISel] Fix known bits for G_ASSERT_ALIGN.

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 22 02:27:17 PDT 2022


aemerson added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/GISelKnownBits.cpp:475
   case TargetOpcode::G_ASSERT_ALIGN: {
-    int64_t LogOfAlign = MI.getOperand(2).getImm();
-    if (LogOfAlign == 0)
----------------
arsenm wrote:
> I thought 0 would be rejected by the verifier. This shouldn’t have been produced 
Ok I'll look into adding a verifier check and removing this handling for 0.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134380/new/

https://reviews.llvm.org/D134380



More information about the llvm-commits mailing list