[PATCH] D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Thanks for working on this. I was also looking into improving the situation, but this patch is more complete.  I pushed an additional test case in 5be203ec4db5 <https://reviews.llvm.org/rG5be203ec4db575302fd287ca5dbf5f4ce18ea609> which also covers the DICompileUnit case. It would need updating to use the `di-metadata` pass here.



================
Comment at: llvm/tools/llvm-reduce/DeltaManager.cpp:64
     DELTA_PASS("aliases", reduceAliasesDeltaPass)                              \
+    DELTA_PASS("function-bodies", reduceFunctionBodiesDeltaPass)               \
+    DELTA_PASS("functions", reduceFunctionsDeltaPass)                          \
----------------
Should this be split off as a separate patch? It seems independent of adding a new DI-metadata reduction pass.


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceDIMetadata.cpp:93
+  }
+  identifyUninterestingMDNodes(O, MDs);
+}
----------------
I think you should also include `DICompileUnit` nodes:  `Program.debug_compile_units()`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132077/new/

https://reviews.llvm.org/D132077