[PATCH] D134421: miscompilation with coroutine since 15.0.0: function has no ret call

Adrian Imboden via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 22 02:03:37 PDT 2022


adrianimboden created this revision.
adrianimboden added reviewers: nikic, ChuanqiXu, fhahn.
Herald added a subscriber: hiraditya.
Herald added a project: All.
adrianimboden requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This patch reverts 10c531cd5bf0166ce5bf42736506733b2285fdf8 <https://reviews.llvm.org/rG10c531cd5bf0166ce5bf42736506733b2285fdf8> (https://reviews.llvm.org/D128796)
It solves https://github.com/llvm/llvm-project/issues/57861.

@fhahn You mentioned in D128796 <https://reviews.llvm.org/D128796>, that the comment saying that this optimization must not be done is irrelevant. Is this comment related to this example?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D134421

Files:
  llvm/lib/Transforms/Scalar/SCCP.cpp
  llvm/test/Transforms/GVN/gvn-loop-load-pre-order.ll
  llvm/test/Transforms/SCCP/2004-12-10-UndefBranchBug.ll
  llvm/test/Transforms/SCCP/2008-01-27-UndefCorrelate.ll
  llvm/test/Transforms/SCCP/preserve-analysis.ll
  llvm/test/Transforms/SCCP/sccptest.ll
  llvm/test/Transforms/SCCP/strictfp-phis-fcmp.ll
  llvm/test/Transforms/SCCP/strictfp-phis-fcmps.ll
  llvm/test/Transforms/SCCP/widening.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134421.462115.patch
Type: text/x-patch
Size: 13048 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220922/2569ed77/attachment.bin>


More information about the llvm-commits mailing list