[PATCH] D133949: Make sure the right parameter extension attributes are added in various instrumentation passes.

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 22 01:42:44 PDT 2022


jonpa added a comment.

> It's a little frustrating to have to fill all these out as it seems they really should only ever be used by clang, or? If so, maybe these functions could have something like an llvm-internal attribute so as to do the same trick as before by safely ignoring them?

At second thought, I think that would not work. The clang front end would add the attributes when building them from the .cpp files so the instrumented declarations really must hold them as well, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133949/new/

https://reviews.llvm.org/D133949



More information about the llvm-commits mailing list