[PATCH] D132657: [DSE] Eliminate noop store even through has clobbering between LoadI and StoreI

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:1888
+                    std::min(CurrentStoreI->getAlign(), LoadI->getAlign()) >=
+                        DL.getTypeStoreSize(LoadI->getType()))
+                  continue;
----------------
Can you please add a test with scalable vectors? Unless we exclude them somewhere earlier already, we would assert here when converting the type size to integer.


================
Comment at: llvm/test/Transforms/DeadStoreElimination/noop-stores.ll:702
+
+define void @store_same_i12_to_mayalias_loc(i12* %q, i12* %p) {
+; CHECK-LABEL: @store_same_i12_to_mayalias_loc(
----------------
Can you please add an `align 1` variant of this test (negative test)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132657/new/

https://reviews.llvm.org/D132657