[PATCH] D132055: [LoopInterchange][PR57148] Ensure LCSSA form after loop interchnange

Congzhe Cao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 21 20:32:39 PDT 2022


congzhe added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopInterchange.cpp:1354
 
-    // Splits the inner loops phi nodes out into a separate basic block.
-    BasicBlock *InnerLoopHeader = InnerLoop->getHeader();
+  // Splits the inner loops phi nodes out into a separate basic block.
+  BasicBlock *InnerLoopHeader = InnerLoop->getHeader();
----------------
Meinersbur wrote:
> [suggestion] Update commend for condition: "Ensure the inner loop phi nodes have a separate basic block."
Thanks, I've updated the patch accordingly and I will land it shortly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132055/new/

https://reviews.llvm.org/D132055



More information about the llvm-commits mailing list