[PATCH] D130483: [RISCV] Add CodeGen support of RISCV Zca Extension

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp:357
                                    const MCSubtargetInfo *STI) const {
   bool HasStdExtC = STI->getFeatureBits()[RISCV::FeatureStdExtC];
+  bool HasStdExtZca = STI->getFeatureBits()[RISCV::FeatureExtZca];
----------------
craig.topper wrote:
> `bool UseCompressedNop = STI->getFeatureBits()[RISCV::FeatureStdExtC] || STI->getFeatureBits()[RISCV::FeatureExtZca]`
> 
> Don't repeat the `||` in two places.
Is there a test for this?


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVMCObjectFileInfo.cpp:21
 unsigned RISCVMCObjectFileInfo::getTextSectionAlignment() const {
   const MCSubtargetInfo *STI = getContext().getSubtargetInfo();
+  return (STI->hasFeature(RISCV::FeatureStdExtC) ||
----------------
Is there a test for this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130483/new/

https://reviews.llvm.org/D130483