[PATCH] D130980: [AA] Model operand bundles more precisely

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Analysis/AliasAnalysis.cpp:238
   // aggregate set of AA results.
-  auto MRB = getModRefBehavior(Call);
-  if (MRB.onlyAccessesInaccessibleMem())
+  auto MRB = getModRefBehavior(Call).getWithoutLoc(
+      FunctionModRefBehavior::InaccessibleMem);
----------------
After staring at this for a bit, I concluded this was correct, but the bit about explicitly ignoring the InaccessibleMem effects here is subtle, and might be worth an explicit call out.  The current comment/structure makes it look like the ignoring InaccessibleMem in lower points might be a mistake.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130980/new/

https://reviews.llvm.org/D130980