[PATCH] D132566: [SLP] Fix cost model w.r.t. operand properties

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 21 13:35:32 PDT 2022


ABataev added a comment.

Check D115757 <https://reviews.llvm.org/D115757>, it supports same kind for all operations.



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:6429
+      auto Op1Info = getOperandInfo(VL, 0);
+      auto Op2Info = getOperandInfo(VL, OpIdx);
       InstructionCost VecCost =
----------------
reames wrote:
> RKSimon wrote:
> > Don't use auto (even though it was used before.....)
> Why?  This is certainly allowed by LLVM coding standards.  
Allowed if it is easy to determine the type, better to use the actual type where possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132566/new/

https://reviews.llvm.org/D132566



More information about the llvm-commits mailing list