[PATCH] D134164: [RelocationResolver] Add R_RISCV_SET8

Wed Sep 21 13:09:22 PDT 2022

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.

================
Comment at: llvm/test/MC/RISCV/cfi-advance.s:6
+
+#RELAX: 0x26 R_RISCV_SET8 - 0x0
+#RELAX-DWARFDUMP-NOT: error: failed to compute relocation
----------------
ditto nearby

================
Comment at: llvm/test/MC/RISCV/cfi-advance.s:7
+#RELAX: 0x26 R_RISCV_SET8 - 0x0
+#RELAX-DWARFDUMP-NOT: error: failed to compute relocation
+        .text
----------------
The negative pattern is not needed. The no-error state is implied by `llvm-dwarfdump` rather than `not llvm-dwarfdump`

You may change `llvm-dwarfdump --debug-info --debug-line` to test some properties to best leverage the test (https://maskray.me/blog/2021-08-08-toolchain-testing "A regression test which simply runs the compiler and expects it not to crash has low utilization. It is often better to additionally test some properties of the produced object file.")

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134164/new/

https://reviews.llvm.org/D134164