[PATCH] D133625: [mlir][MemRef] Simplify extract_strided_metadata(expand_shape)

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: mlir/lib/Dialect/MemRef/Transforms/SimplifyExtractStridedMetadata.cpp:177
+static SmallVector<OpFoldResult>
+getExpandedSizes(memref::ExpandShapeOp expandShape, OpBuilder &builder,
+                 const SmallVectorImpl<OpFoldResult> &origSizes,
----------------
nicolasvasilache wrote:
> I would make this a first-class citizen of expand: `SmallVector<OpFoldResult> memref::ExpandShapeOp::buildExpandedSizes(...)`.
> 
> Then as the op semantics evolve to take the result shape operands, we can update this.
That's not possible because the MemRef dialect would depend on Affine dialect if we were to do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133625/new/

https://reviews.llvm.org/D133625