[PATCH] D134322: [llvm-libtool-darwin] Add support for -dependency_info

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo accepted this revision.
oontvoo added a comment.
This revision is now accepted and ready to land.

LG (with a nit)

(I don't know who else needs to stamp this)



================
Comment at: llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp:665
 
+  GlobalDependencyInfo = std::make_unique<DependencyInfo>(DependencyInfoPath);
+
----------------
[nit] How important is performance for this tool, do you know? Is it worth removing the `if (Active)` check in the DependencyInfo class, and instead movign the logic here so that the check is done only once:


```
GlobalDependencyInfo = DependencyInfoPath.empty() 
                                                ? std::make_unique<DummyDependencyInfo>()  // A subclass that doesn't do anything
                                                : std::make_unique<DependencyInfo>(DependencyInfoPath);

```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134322/new/

https://reviews.llvm.org/D134322