[PATCH] D134234: [llvm] Support forward-referenced globals with dso_local_equivalent

Leonard Chan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 21 12:31:59 PDT 2022


leonardchan marked 2 inline comments as done.
leonardchan added inline comments.


================
Comment at: llvm/test/CodeGen/X86/dso_local_equivalent_undefined_func.ll:1
+; RUN: not llc -mtriple=x86_64-linux-gnu -o - %s 2>&1 | FileCheck %s
+
----------------
MaskRay wrote:
> Instead of having 3 test files, if merging improves readability, check out `split-file`. I think at the least the two invalid tests should be combined.
First time learning about this. Very useful!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134234/new/

https://reviews.llvm.org/D134234



More information about the llvm-commits mailing list