[PATCH] D133456: [V2] MC: make section classification a bit more thorough

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 21 11:24:50 PDT 2022


compnerd marked an inline comment as done.
compnerd added inline comments.


================
Comment at: llvm/lib/MC/MCContext.cpp:587
+               .StartsWith(".debug_", SectionKind::getMetadata())
+               .Default(SectionKind::getText());
 
----------------
MaskRay wrote:
> As discussed, we need a comment that we choose `SectionKind::getText()` because of an unknown `Kind` (like a forward declaration) and this is used by `R_RISCV_{ADD,SUB}*`
Added such a comment.  Happy to adjust the comment if you feel it's unclear or overly verbose.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133456/new/

https://reviews.llvm.org/D133456



More information about the llvm-commits mailing list