[PATCH] D133456: [V2] MC: make section classification a bit more thorough
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 21 10:38:15 PDT 2022
MaskRay added inline comments.
================
Comment at: llvm/lib/MC/MCContext.cpp:587
+ .StartsWith(".debug_", SectionKind::getMetadata())
+ .Default(SectionKind::getText());
----------------
As discussed, we need a comment that we choose `SectionKind::getText()` because of an unknown `Kind` (like a forward declaration) and this is used by `R_RISCV_{ADD,SUB}*`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133456/new/
https://reviews.llvm.org/D133456
More information about the llvm-commits
mailing list