[PATCH] D132199: [LoopPassManager] Ensure to construct loop nests with the outermost loop

[Congzhe Cao via Phabricator via llvm-commits]

congzhe added a comment.

In D132199#3796658 <https://reviews.llvm.org/D132199#3796658>, @aeubanks wrote:

> thanks, lgtm with one nit
> sorry for the long back and forth
>
> I do think that the loop nest infrastructure in general needs some work and doesn't fit in with the rest of the new pass manager infrastructure very well. there should have been an RFC (unless I missed it)

Thank you very much! I've done a minor update to address the minor comment. I'll land it shortly.

Regarding preventing infinite interchanging: thanks for your suggestion, this is definitely helpful and using metadata could be a way to resolving the infinite interchange. Another direction is to improve the cost analysis. I'll think more about it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132199/new/

https://reviews.llvm.org/D132199