[PATCH] D132392: [SVE] Extend getMemVTFromNode to cover the sret variants of sve.ld2/3/4.
Paul Walker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 21 10:16:47 PDT 2022
paulwalker-arm added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:5153
- if (Opcode != ISD::INTRINSIC_VOID)
+ if (Opcode != ISD::INTRINSIC_VOID && Opcode != ISD::INTRINSIC_W_CHAIN)
return EVT();
----------------
CarolineConcatto wrote:
> I believe you can remove this test, no?
> It should fall into the default switch statement.
>
The opcode infers things like the number and type of operands and so this test ensures it's safe to do `cast<ConstantSDNode>(Root->getOperand(1))->getZExtValue()`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132392/new/
https://reviews.llvm.org/D132392
More information about the llvm-commits
mailing list