[llvm] f47a5df - [lit] Try to fix new test from 28412d1800e3 under Windows

[Joel E. Denny via llvm-commits]

Author: Joel E. Denny
Date: 2022-09-21T12:06:41-04:00
New Revision: f47a5df92d488bdff418e3b1d249f407885896f2

URL: https://github.com/llvm/llvm-project/commit/f47a5df92d488bdff418e3b1d249f407885896f2
DIFF: https://github.com/llvm/llvm-project/commit/f47a5df92d488bdff418e3b1d249f407885896f2.diff

LOG: [lit] Try to fix new test from 28412d1800e3 under Windows

`llvm/utils/lit/tests/Inputs/shtest-define/value-escaped.txt` broke at
least at <https://lab.llvm.org/buildbot/#/builders/216/builds/10114>.

The problem appears to be a non-portable `echo` command line.

Added: 
    

Modified: 
    llvm/utils/lit/tests/Inputs/shtest-define/lit.cfg

Removed: 
    


################################################################################
diff  --git a/llvm/utils/lit/tests/Inputs/shtest-define/lit.cfg b/llvm/utils/lit/tests/Inputs/shtest-define/lit.cfg
index acdb27d005b3..7f0d1f7c2e46 100644
--- a/llvm/utils/lit/tests/Inputs/shtest-define/lit.cfg
+++ b/llvm/utils/lit/tests/Inputs/shtest-define/lit.cfg
@@ -1,7 +1,10 @@
 import lit.formats
 config.name = 'shtest-define'
 config.suffixes = ['.txt']
-config.test_format = lit.formats.ShTest()
+# Use lit's internal shell to avoid shell portability issues within RUN lines
+# (e.g., for 'echo' commands in Windows).  Those issues should be orthogonal to
+# the substitution behavior we are trying to test.
+config.test_format = lit.formats.ShTest(execute_external=False)
 config.test_source_root = None
 config.test_exec_root = None