[PATCH] D134322: [llvm-libtool-darwin] Add support for -dependency_info

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added inline comments.


================
Comment at: llvm/tools/llvm-libtool-darwin/DependencyInfo.h:46
+    auto AddDep = [&OS](DependencyInfoOpcode Opcode, const std::string &Path) {
+      llvm::errs() << "writing dependency: " << Path << "\n";
+      OS << static_cast<uint8_t>(Opcode);
----------------
Is this intentional? (ie., logging to errs()? ) I wonder if there's a "debug()" or something similar so that it'd look less suspicious)


================
Comment at: llvm/tools/llvm-libtool-darwin/DependencyInfo.h:55
+    // Sort the input by its names.
+    std::vector<std::string> InputNames;
+    InputNames.reserve(Inputs.size());
----------------
nit: could use StringRef here? (given we're not modifying the strings, so no need for the extra copies?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134322/new/

https://reviews.llvm.org/D134322