[llvm] 46e036b - [CostModel][X86] Remove out of date TODO

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 21 05:26:13 PDT 2022


Author: Simon Pilgrim
Date: 2022-09-21T13:25:38+01:00
New Revision: 46e036b5c23e824391a96c9586f5e00ba775b91d

URL: https://github.com/llvm/llvm-project/commit/46e036b5c23e824391a96c9586f5e00ba775b91d
DIFF: https://github.com/llvm/llvm-project/commit/46e036b5c23e824391a96c9586f5e00ba775b91d.diff

LOG: [CostModel][X86] Remove out of date TODO

ROTR constant and uniform-constant tests were added some time ago by 2fe1076a0888b4cdc22abc33ef2e5d9a7d8de1b1

Added: 
    

Modified: 
    llvm/test/Analysis/CostModel/X86/fshr-codesize.ll
    llvm/test/Analysis/CostModel/X86/fshr-latency.ll
    llvm/test/Analysis/CostModel/X86/fshr-sizelatency.ll
    llvm/test/Analysis/CostModel/X86/fshr.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/Analysis/CostModel/X86/fshr-codesize.ll b/llvm/test/Analysis/CostModel/X86/fshr-codesize.ll
index 4b678d205990..67d332fbed82 100644
--- a/llvm/test/Analysis/CostModel/X86/fshr-codesize.ll
+++ b/llvm/test/Analysis/CostModel/X86/fshr-codesize.ll
@@ -1250,7 +1250,6 @@ define void @splatconstant_funnel_i8(i8 %a8, <16 x i8> %a128, <32 x i8> %a256, <
 ;
 ; Variable Unary Funnel Shifts (Rotates)
 ;
-; TODO - Add constant and uniform-constant tests
 
 define void @var_rotate_i64(i64 %a64, <2 x i64> %a128, <4 x i64> %a256, <8 x i64> %a512, i64 %c64, <2 x i64> %c128, <4 x i64> %c256, <8 x i64> %c512) {
 ; SSE-LABEL: 'var_rotate_i64'

diff  --git a/llvm/test/Analysis/CostModel/X86/fshr-latency.ll b/llvm/test/Analysis/CostModel/X86/fshr-latency.ll
index fdc86be0e30b..e1e3a65bfa50 100644
--- a/llvm/test/Analysis/CostModel/X86/fshr-latency.ll
+++ b/llvm/test/Analysis/CostModel/X86/fshr-latency.ll
@@ -1202,7 +1202,6 @@ define void @splatconstant_funnel_i8(i8 %a8, <16 x i8> %a128, <32 x i8> %a256, <
 ;
 ; Variable Unary Funnel Shifts (Rotates)
 ;
-; TODO - Add constant and uniform-constant tests
 
 define void @var_rotate_i64(i64 %a64, <2 x i64> %a128, <4 x i64> %a256, <8 x i64> %a512, i64 %c64, <2 x i64> %c128, <4 x i64> %c256, <8 x i64> %c512) {
 ; SSE-LABEL: 'var_rotate_i64'

diff  --git a/llvm/test/Analysis/CostModel/X86/fshr-sizelatency.ll b/llvm/test/Analysis/CostModel/X86/fshr-sizelatency.ll
index b2160aa34ac6..286db587b3ce 100644
--- a/llvm/test/Analysis/CostModel/X86/fshr-sizelatency.ll
+++ b/llvm/test/Analysis/CostModel/X86/fshr-sizelatency.ll
@@ -1370,7 +1370,6 @@ define void @splatconstant_funnel_i8(i8 %a8, <16 x i8> %a128, <32 x i8> %a256, <
 ;
 ; Variable Unary Funnel Shifts (Rotates)
 ;
-; TODO - Add constant and uniform-constant tests
 
 define void @var_rotate_i64(i64 %a64, <2 x i64> %a128, <4 x i64> %a256, <8 x i64> %a512, i64 %c64, <2 x i64> %c128, <4 x i64> %c256, <8 x i64> %c512) {
 ; SSE-LABEL: 'var_rotate_i64'

diff  --git a/llvm/test/Analysis/CostModel/X86/fshr.ll b/llvm/test/Analysis/CostModel/X86/fshr.ll
index a11d968d2050..b5d950b060a6 100644
--- a/llvm/test/Analysis/CostModel/X86/fshr.ll
+++ b/llvm/test/Analysis/CostModel/X86/fshr.ll
@@ -1195,7 +1195,6 @@ define void @splatconstant_funnel_i8(i8 %a8, <16 x i8> %a128, <32 x i8> %a256, <
 ;
 ; Variable Unary Funnel Shifts (Rotates)
 ;
-; TODO - Add constant and uniform-constant tests
 
 define void @var_rotate_i64(i64 %a64, <2 x i64> %a128, <4 x i64> %a256, <8 x i64> %a512, i64 %c64, <2 x i64> %c128, <4 x i64> %c256, <8 x i64> %c512) {
 ; SSE-LABEL: 'var_rotate_i64'


        


More information about the llvm-commits mailing list