[PATCH] D133256: [ARM64EC 14/?] Set comdat for thunks and enable wowthk section to help reduce thunk numbers

chenglin.bi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 21 05:05:32 PDT 2022


bcl5980 added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64Arm64ECCallLowering.cpp:245
+      if (!CB->getParamAttr(i, Attribute::StructRet).isValid())
+        ArgType = CanonicalizeThunkType(ArgType);
+      DefArgTypes.push_back(ArgType);
----------------
efriedma wrote:
> What does "canonicalizing" like this accomplish?
For example int f(int) share the same thunk to char f(char).
If we want to eliminate duplicate thunks we need to map all original pow2 interger types less than 64bit to 64bit.
The goal for this function is following msvc's arm64ec thunk naming rule. Generate the thunk type from original function type.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133256/new/

https://reviews.llvm.org/D133256



More information about the llvm-commits mailing list