[PATCH] D125776: [llvm-debuginfo-analyzer] 01 - Interval tree
Carlos Alberto Enciso via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 21 00:29:03 PDT 2022
CarlosAlbertoEnciso updated this revision to Diff 461802.
CarlosAlbertoEnciso added a comment.
Address review from @probinson:
- Document and test the case where the interval 'Left' and 'Right' are the same.
- Add an assertion to check that 'Left <= Right'.
- Disallow pointer types for 'PointT'.
- Change 'EXPECT_EQ(cond, true)' to 'EXPECT_TRUE(cond)'.
- Some minor comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125776/new/
https://reviews.llvm.org/D125776
Files:
llvm/docs/ProgrammersManual.rst
llvm/include/llvm/ADT/IntervalTree.h
llvm/unittests/ADT/CMakeLists.txt
llvm/unittests/ADT/IntervalTreeTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125776.461802.patch
Type: text/x-patch
Size: 89509 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220921/7cb239fd/attachment-0001.bin>
More information about the llvm-commits
mailing list