[PATCH] D134266: Introduce predicate for a atomic operations in GMIR

Sameer Sahasrabuddhe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 22:23:23 PDT 2022


sameerds added a comment.

In D134266#3804612 <https://reviews.llvm.org/D134266#3804612>, @arsenm wrote:

> I don't know how much use a general "isAtomic" predicate will be. You wouldn't really do anything with the same operand indices for all of them. An isAtomicRMW would be more useful?

It will need to be "isAtomicRead" to include AtomicLoad and AtomicRMW. Basically any atomic operation that returns a value. We assume that by its very nature of being atomic, the returned value can be different in each thread. Fence is not relevant for this use-case since it does not access memory or return anything; it merely orders operations within the same thread.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134266/new/

https://reviews.llvm.org/D134266



More information about the llvm-commits mailing list