[PATCH] D133992: [objdump] Add --build-id flag for debuginfod lookups without binary.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.

> `[objdump]`

We commonly use `[llvm-objdump]`. objdump refers to the GNU binutils one.



================
Comment at: llvm/test/tools/llvm-objdump/debuginfod.test:34
+# Use debuginfod to look up build IDs.
+RUN: env DEBUGINFOD_CACHE_PATH=%t llvm-objdump -d --source \
+RUN:   --build-id 1512f769114c011387393822af15dd660c080295 | \
----------------
Optional: The lines in this file appear to be wrapped too aggressively. Two lines seem sufficient if you place `--build-id` on the previous line.


================
Comment at: llvm/test/tools/llvm-objdump/debuginfod.test:41
+RUN:   --build-id foo 2> %t.err
+RUN:   FileCheck %s --check-prefix=MALFORMEDERROR --input-file %t.err
+MALFORMEDERROR: error: --build-id: expected a build ID, but got 'foo'
----------------
FileCheck line should not be indented.


================
Comment at: llvm/test/tools/llvm-objdump/debuginfod.test:47
+RUN:   --build-id abc 2> %t.err
+RUN:   FileCheck %s --check-prefix=NOTFOUNDERROR --input-file %t.err
+NOTFOUNDERROR: error: --build-id: could not find build ID 'abc'
----------------
FileCheck line should not be indented.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133992/new/

https://reviews.llvm.org/D133992