[PATCH] D134087: [TableGen] Track reference locations of Records/RecordVals
    Chris Lattner via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Sep 20 17:39:24 PDT 2022
    
    
  
lattner added a comment.
> The problem that I ran into was that a lot of stuff kind of requires that the Inits get folded and are uniqued, which would no longer be the case if we put locations on them. From there this patch arose, because I didn't want to broach the "rewrite the world" just to get better locations.
Aha, I didn't remember that, yes I agree that you cannot unique things if they carry locations.  If that is inherent to how tblgen works, then ok.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134087/new/
https://reviews.llvm.org/D134087
    
    
More information about the llvm-commits
mailing list