[PATCH] D134234: [llvm] Support forward-referenced globals with dso_local_equivalent

Leonard Chan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 15:43:21 PDT 2022


leonardchan added inline comments.


================
Comment at: llvm/lib/AsmParser/LLParser.cpp:220
+  // are references after the function was defined.  Resolve those now.
+  while (!ForwardRefDSOLocalEquivalents.empty()) {
+    GlobalValue *GV = nullptr;
----------------
MaskRay wrote:
> Use a range-based for loop and clear `ForwardRefDSOLocalEquivalents`?
Right. Had this but forgot to update the diff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134234/new/

https://reviews.llvm.org/D134234



More information about the llvm-commits mailing list