[PATCH] D134308: AtomicExpand: Use llvm.ptrmask instead of ptrtoint

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 15:36:35 PDT 2022


jyknight added a comment.

In D134308#3804305 <https://reviews.llvm.org/D134308#3804305>, @arsenm wrote:

> In D134308#3804295 <https://reviews.llvm.org/D134308#3804295>, @jyknight wrote:
>
>> Can you explain what effect you expect this to have? It removes all the inttoptr -- maybe that's useful in itself?
>
> Moving towards the goal of never having compiler introduced inttoptr

That was sort of my guess -- but, then, this change already DOES fix (this part of) the problem, right? We have a ptrtoint remaining, but not an inttoptr -- that should be fine?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134308/new/

https://reviews.llvm.org/D134308



More information about the llvm-commits mailing list