[PATCH] D130949: [NFC][NewGVN] Remove OpIsSafeForPHIOfOpsHelper()

Konstantina Mitropoulou via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 13:59:41 PDT 2022


kmitropoulou added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/NewGVN.cpp:2919
 
 void NewGVN::cleanupTables() {
   for (CongruenceClass *&CC : CongruenceClasses) {
----------------
kmitropoulou wrote:
> asbirlea wrote:
> > Could you move this to a separate NFC patch?
> I did not do this change. It is shown here because this change was committed in September 3rd.
It came from the following commit:

commit fedc59734a44ef7b62c5f389b0cdffd02264b2a9
Author: Kazu Hirata <kazu at google.com>
Date:   Sat Sep 3 11:17:40 2022 -0700

    [llvm] Use range-based for loops (NFC)



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130949/new/

https://reviews.llvm.org/D130949



More information about the llvm-commits mailing list