[PATCH] D130221: [ORC] Fix macho section name typo

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D130221#3803469 <https://reviews.llvm.org/D130221#3803469>, @keith wrote:

> Yea the only tests around this code I found are https://github.com/llvm/llvm-project/blob/f2949febf354eb8aded7db3e63d2c878fe86db3b/llvm/unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp which aren't a ton of coverage. From the initial commit of this logic https://github.com/llvm/llvm-project/commit/0fda4c4745b81e8a0eed2b80b0b03f33c16c2b99 my assumption is no other tests are covering this today

Looks like that original commit does have source coverage of this function (adding an `assert(false)` fails only that unit test) but the behavior is not verified (hardcoding the function's return (to either `true` or `false`)).

@lhames - is there some way this functionality should be observable in that unit test? Or covered in some other way?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130221/new/

https://reviews.llvm.org/D130221