[PATCH] D133972: [AMDGPU] Fix size of SOPK instructions to 4 bytes
Anshil Gandhi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 20 13:27:41 PDT 2022
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa0c53524a55d: [AMDGPU] Fix size of SOPK instructions to 4 bytes (authored by gandhi21299).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133972/new/
https://reviews.llvm.org/D133972
Files:
llvm/lib/Target/AMDGPU/SOPInstructions.td
llvm/test/CodeGen/AMDGPU/sopk-no-literal.ll
Index: llvm/test/CodeGen/AMDGPU/sopk-no-literal.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/AMDGPU/sopk-no-literal.ll
@@ -0,0 +1,24 @@
+; REQUIRES: asserts
+; RUN: llc -O0 -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1100 -debug-only=branch-relaxation -verify-machineinstrs < %s 2>&1 | FileCheck --check-prefix=GFX10 %s
+
+; GFX10: Basic blocks after relaxation
+; GFX10: %bb.0 offset=00000000 size=0x1c
+
+; Each instruction in the following kernel is 4 bytes in size,
+; except s_load_b32 which is 8 bytes in size. Hence, 0x1c bytes in total.
+define amdgpu_kernel void @test_sopk_size(i32 %var.mode) {
+; GFX10-LABEL: test_sopk_size:
+; GFX10: ; %bb.0:
+; GFX10: s_load_b32 s0, s[0:1], 0x0
+; GFX10: s_mov_b32 s1, 3
+; GFX10: s_setreg_b32 hwreg(HW_REG_MODE, 0, 2), s1
+; GFX10: s_waitcnt lgkmcnt(0)
+; GFX10: s_setreg_b32 hwreg(HW_REG_MODE, 0, 3), s0
+; GFX10: s_endpgm
+ call void @llvm.amdgcn.s.setreg(i32 2049, i32 3)
+ call void @llvm.amdgcn.s.setreg(i32 4097, i32 %var.mode)
+ call void asm sideeffect "", ""()
+ ret void
+}
+
+declare void @llvm.amdgcn.s.setreg(i32 immarg, i32)
Index: llvm/lib/Target/AMDGPU/SOPInstructions.td
===================================================================
--- llvm/lib/Target/AMDGPU/SOPInstructions.td
+++ llvm/lib/Target/AMDGPU/SOPInstructions.td
@@ -722,6 +722,7 @@
let hasSideEffects = 0;
let SALU = 1;
let SOPK = 1;
+ let FixedSize = 1;
let SchedRW = [WriteSALU];
let UseNamedOperandTable = 1;
string Mnemonic = opName;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133972.461681.patch
Type: text/x-patch
Size: 1569 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220920/145bcb33/attachment.bin>
More information about the llvm-commits
mailing list