[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 12:11:09 PDT 2022


nikic added a comment.

Please drop the clang test and use update_test_checks.py for LLVM tests.



================
Comment at: llvm/test/Transforms/MergeFunc/dso_local_equivalent_merged.ll:1
+;; Check the cases involving dso_local_equivalent where we do expect functions to be merged.
+; RUN: opt -S -mergefunc < %s | FileCheck %s
----------------
Based on your check lines, it doesn't look like the functions actually get merged? You probably need to add some dummy instructions to pass the instruction threshold, or use internal linkage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134300/new/

https://reviews.llvm.org/D134300



More information about the llvm-commits mailing list