[PATCH] D133974: [objcopy] Fix order of Mach-O LINKEDIT pieces during layout

[Daniel Rodríguez Troitiño via Phabricator via llvm-commits]

drodriguez added a comment.

In D133974#3801858 <https://reviews.llvm.org/D133974#3801858>, @alexander-shaposhnikov wrote:

> see a small nit above,  otherwise - looks good to me.
> p.s. https://reviews.llvm.org/D119671 seems to be relevant, don't know the current status of that effort though.
> It would be good to review/land D134250 <https://reviews.llvm.org/D134250> or D119671 <https://reviews.llvm.org/D119671>, alternatively i think it's reasonable to add a TODO (that we should add a test once ObjectYAML is ready) and commit this fix now. 
> cc: @thakis , @keith

Yes. It seems @keith and me filled the same gap. My version includes the "DataInCode" part which I wanted to test as many pieces as I could in the linkedit order.

About not waiting for D134250 <https://reviews.llvm.org/D134250> (or equivalent), the test will have to be reduced a lot (and it is already missing some pieces about bindings that I don't know how to generate properly). Unless I end up in a review blockage, I will keep the dependency for the moment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133974/new/

https://reviews.llvm.org/D133974