[PATCH] D134161: [MemorySSA] Reset location size if IsGuaranteedLoopInvariant after phi tranlation
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 20 11:14:00 PDT 2022
nikic added inline comments.
================
Comment at: llvm/include/llvm/Analysis/MemorySSA.h:1273
+ CurrentPair.second =
+ CurrentPair.second.getWithNewSize(Location.Size);
+
----------------
The logic here looks somewhat convoluted -- isn't this equivalent to doing the translation first and then doing the invariance check afterwards (dropping the size adjustment before phi translation entirely)?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134161/new/
https://reviews.llvm.org/D134161
More information about the llvm-commits
mailing list