[PATCH] D134250: [ObjectYAML] Support chained fixups, dyld exports trie, data in code

[Daniel Rodríguez Troitiño via Phabricator via llvm-commits]

drodriguez added a comment.

In D134250#3802961 <https://reviews.llvm.org/D134250#3802961>, @beanz wrote:

> When I added the initial mach-o support the emphasis was on representing the binary accurately enough to reproduce binary-accurate transformations, but to also have the YAML representation be human readable wherever it could be. This patch really just treats it as binary data, which makes it pretty unreadable.

Agree 100%. The need from this come from D133974 <https://reviews.llvm.org/D133974>. I had the need of testing that the data was moved correctly during objcopy, but I don't have the need to inspect the data itself. My hope is that whenever someone has the need to check that the data is actually representing the right thing, they will have the knowledge of what the data represents and how better transform it into YAML. I prefer not to check-in executables in the source tree, but if we don't even want this code as a temporary solution, I think I can work around the need of adding this support.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134250/new/

https://reviews.llvm.org/D134250