[PATCH] D130221: [ORC] Fix macho section name typo

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D130221#3802866 <https://reviews.llvm.org/D130221#3802866>, @keith wrote:

> I poked around for an hour or so trying to get something working here, but I'm not familiar with how these types fit together at all, so I couldn't come up with something for this. (I just spotted this typo looking around for other uses of __objc_selrefs in general). I was attempting to write a test where I added one of these sections to the link graph, and then looked up the init symbol that should be added, any tips for how to test this would be appreciated!

Assuming some of this code is already tested, one way to find the existing test coverage would be to remove this whole `for`+`if` and let the function always return false - then run the llvm (& maybe compiler-rt) tests and see what fails - hopefully something fails, and that'll point you to tests that exercise this code. If that doesn't turn up anything, because the tests are possibly underconstrained, you could try adding an assertion that the name isn't any of the ones in this list - then at least if a test exercises any of these names you'd hit an assertion and could figure out if the behavior was observable...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130221/new/

https://reviews.llvm.org/D130221