[PATCH] D133441: [SLP] Vectorize mutual horizontal reductions.

Alexandros Lamprineas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 10:09:09 PDT 2022


labrinea updated this revision to Diff 461599.
labrinea retitled this revision from "[SLP] Look ahead for mutual horizontal reductions." to "[SLP] Vectorize mutual horizontal reductions.".
labrinea added a comment.

I tried to follow the review suggestions as close as possible. However I am not sure about the conditions inside `cacheVectorizableValues()` and those that determine the value of `SkipCost`. Relaxing them makes the change to trigger way too broadly resulting additional insert/extract element instructions in the unit tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133441/new/

https://reviews.llvm.org/D133441

Files:
  llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
  llvm/test/Transforms/SLPVectorizer/AArch64/multiple_reduction.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133441.461599.patch
Type: text/x-patch
Size: 46135 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220920/d08a5e02/attachment.bin>


More information about the llvm-commits mailing list