[PATCH] D133667: [InstCombine] convert mul by negative-pow2 to negate and shift

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 10:05:06 PDT 2022


spatel added a comment.

In D133667#3803056 <https://reviews.llvm.org/D133667#3803056>, @RKSimon wrote:

> No objections, but I'm a little worried that the negator will put up a fight and convert this back again.....

Yes - I want to believe that the zext protects us from getting into an infinite loop (we shouldn't widen the sub unless it allows removing some other instructions), but it's hard to guarantee that there isn't some loophole.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133667/new/

https://reviews.llvm.org/D133667



More information about the llvm-commits mailing list