[PATCH] D132837: [ISel] Enable generating more fma instructions.

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

In D132837#3802595 <https://reviews.llvm.org/D132837#3802595>, @foad wrote:

> I am a little confused by the test changes: one of them now uses fmac instead of mac, and the other uses mad instead of fma.

This is not your fault and need not block the patch. The choice of fma vs fmad depends on whether the combiner is running pre- or post-legalization, and it is a bit random because the pre-legalization combiner does not always re-run combines on new nodes that it creates, so some stuff is (wrongly) left for the post-legalizer combiner to clean up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132837/new/

https://reviews.llvm.org/D132837