[PATCH] D134015: [Utils] Refactor update_cc_test_checks.py to use shutil

ben via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 08:54:14 PDT 2022


bd1976llvm added a comment.

I reverted this change as it breaks the tests on windows. It seems that distutils.spawn.find_executable is not exactly equivalent to shutil.which on Windows as the former adds ".exe" and the latter adds the extensions from PATHEXT. Furthermore we are invoking these functions on a full path e.g. "C:\p\15\vs2019\bin\clang" and looking at the docs I'm not sure what the behaviour of either function should be in that case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134015/new/

https://reviews.llvm.org/D134015



More information about the llvm-commits mailing list