[PATCH] D134281: [CGP] Update MemIntrinsic alignment if possible

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added inline comments.


================
Comment at: llvm/test/CodeGen/X86/memset-2.ll:8-18
+; CHECK-NEXT:    movaps %xmm0, 160
+; CHECK-NEXT:    movaps %xmm0, 144
+; CHECK-NEXT:    movaps %xmm0, 128
+; CHECK-NEXT:    movaps %xmm0, 112
+; CHECK-NEXT:    movaps %xmm0, 96
+; CHECK-NEXT:    movaps %xmm0, 80
+; CHECK-NEXT:    movaps %xmm0, 64
----------------
pengfei wrote:
> Not sure if the use of `movaps` is a good idea considering the test in below file.
I guess the real fix would be to not use null as the destination. I'm not sure what the test is actually checking, but I could change it to be an argument?


================
Comment at: llvm/test/Transforms/CodeGenPrepare/X86/memset_chk-simplify-nobuiltin.ll:14
 ; CHECK-LABEL: @test_nobuiltin(
-; CHECK-NEXT:    call void @llvm.memset.p0i8.i64(i8* [[DST:%.*]], i8 0, i64 [[LEN:%.*]], i1 false) #1
+; CHECK-NEXT:    call void @llvm.memset.p0i8.i64(i8* align 1 [[DST:%.*]], i8 0, i64 [[LEN:%.*]], i1 false) #[[ATTR1:[0-9]+]]
 ; CHECK-NEXT:    ret void
----------------
pengfei wrote:
> No `ATTR1` to match with it. Just removing the `#1` instead?
Yeah will regen with --scrub-attributes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134281/new/

https://reviews.llvm.org/D134281