[PATCH] D132513: [lit] Implement DEFINE and REDEFINE directives

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D132513#3802792 <https://reviews.llvm.org/D132513#3802792>, @jhenderson wrote:

> My personal opinion is that it's fine as long as there is pretty much zero risk of a downstream user running into spurious passes due to the change from a FileCheck directive to a lit command. In 99% of cases, I think it'll likely fail due to an invalid definition, so I think we're good, personally. (Plus strictly, `LIT-DEF` could already be in use downstream anyway).

I agree, but I wasn't confident. Thanks for giving a second opinion.

OK, I'll try to land tomorrow provided no one else comments on the patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132513/new/

https://reviews.llvm.org/D132513