[PATCH] D134266: Introduce predicate for a atomic operations in GMIR

[Yashwant Singh via Phabricator via llvm-commits]

yassingh added inline comments.


================
Comment at: llvm/include/llvm/Support/TargetOpcodes.def:395
+// Marker of end of Generic Atomic opcodes
+HANDLE_TARGET_OPCODE_MARKER(PRE_ISEL_GENERIC_ATOMIC_OPCODE_END, G_ATOMICRMW_FMIN)
+HANDLE_TARGET_OPCODE_MARKER(GENERIC_ATOMIC_OP_END, PRE_ISEL_GENERIC_ATOMIC_OPCODE_END)
----------------
arsenm wrote:
> yassingh wrote:
> > sameerds wrote:
> > > Why is this marker needed? Should OP_END be sufficient to pair with OP_START?
> > Yes it's not, OP_START and OP_END should be sufficient, will update
> Why doesn't G_FENCE count?
I have a doubt too, could not find details about this instruction. Should this also be included?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134266/new/

https://reviews.llvm.org/D134266