[PATCH] D132513: [lit] Implement DEFINE and REDEFINE directives
Joel E. Denny via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 20 07:24:56 PDT 2022
jdenny added a comment.
@jhenderson: Thanks for the review!
All: There has been no discussion so far on the directive name collisions, as described in the review summary:
> One issue is that the strings `DEFINE:` and `REDEFINE:` already appear in 5 tests. This patch adjusts those tests not to use those strings. Alternatively, maybe lit keywords from now on should start with `LIT-` to avoid collisions. For this patch, we might use `LIT-DEF:` and `LIT-REDEF:`.
If I don't hear any opinions on this within a couple days, I'll go ahead and land the patch with the current names (`DEFINE:` and `REDEFINE:`). Thanks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132513/new/
https://reviews.llvm.org/D132513
More information about the llvm-commits
mailing list