[PATCH] D130903: [AArch64][GlobalISel] Lower formal arguments of AAPCS & ms_abi variadic functions.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 07:16:11 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64CallLowering.cpp:554
+  bool IsWin64CC =
+      Subtarget.isCallingConvWin64(MF.getFunction().getCallingConv());
+  const LLT p0 = LLT::pointer(0, 64);
----------------
You should consistently get the calling convention from CCState, not the parent function. It's wrong in outgoing contexts


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130903/new/

https://reviews.llvm.org/D130903



More information about the llvm-commits mailing list