[PATCH] D133896: [AArch64][SME] Add codegen pass to handle ZA state in arm_new_za functions.

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 07:06:32 PDT 2022


aemerson added a comment.

Using an IR pass to implement ABI doesn't seem right to me. This could be done at codegen time, and having it at the IR level places implicit constraints on later IR passes that aren't enforced.

Even the IR pass was the right choice, I don't see anything here that necessitates a Module pass instead of the usual FunctionPass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133896/new/

https://reviews.llvm.org/D133896



More information about the llvm-commits mailing list